-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Throughput measure for GaudiDDPMPipeline #1460
Conversation
@jiminha @emascarenhas |
@deepak-gowda-narayana nice catch! You are right throughput typically measures the number of units processed per unit of time and here it is inverse of that! Would you please post the tests and failures before this PR? |
Sure, here is the previous test summary without the fix: Result Summary of fast_tests.sh python -m pytest tests/test_gaudi_configuration.py tests/test_trainer_distributed.py tests/test_trainer.py tests/test_trainer_seq2seq.py Result Summary of fast_tests_diffusers.sh python -m pytest tests/test_diffusers.py Result Summary of slow_tests_diffusers.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0f47121
to
6b8ad21
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
The test GaudiDDPMPipelineTester::test_no_throughput_regression_bf16() fails with throughput comparison, but throughput was being measured inversely as sec/sample instead of samples /sec.
This PR does the follow
Below is the summary of slow_diffusion tests
python -m pytest tests/test_diffusers.py -v -s -k "test_textual_inversion"
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /mnt/oh_pr
configfile: setup.cfg
collecting ... collected 159 items / 158 deselected / 1 selected
========== 1 passed, 158 deselected, 5 warnings in 160.91s (0:02:40) ===========
python -m pytest tests/test_diffusers.py -v -s -k "test_train_text_to_image_"
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /mnt/oh_pr
configfile: setup.cfg
collecting ... collected 159 items / 157 deselected / 2 selected
========== 2 passed, 157 deselected, 3 warnings in 486.10s (0:08:06) ===========
python -m pytest tests/test_diffusers.py -v -s -k "test_train_controlnet"
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /mnt/oh_pr
configfile: setup.cfg
collecting ... collected 159 items / 157 deselected / 2 selected
========== 2 passed, 157 deselected, 5 warnings in 201.56s (0:03:21) ===========
python -m pytest tests/test_diffusers.py -v -s -k "test_deterministic_image_generation"
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /mnt/oh_pr
configfile: setup.cfg
collecting ... collected 159 items / 157 deselected / 2 selected
========== 2 passed, 157 deselected, 6 warnings in 276.77s (0:04:36) ===========
python -m pytest tests/test_diffusers.py -v -s -k "test_no_"
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /mnt/oh_pr
configfile: setup.cfg
collecting ... collected 159 items / 153 deselected / 6 selected
===== 5 passed, 1 skipped, 153 deselected, 6 warnings in 416.68s (0:06:56) =====
Before submitting