Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fused rotary embedding #6

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Fused rotary embedding #6

merged 10 commits into from
Jan 9, 2024

Conversation

3outeille
Copy link
Member

No description provided.

@3outeille 3outeille self-assigned this Dec 18, 2023
NouamaneTazi
NouamaneTazi reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@NouamaneTazi NouamaneTazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🎉 Left some comments before we can merge this 🔥

benchmark/benchmark_generation.py Outdated Show resolved Hide resolved
benchmark/benchmark_generation.py Outdated Show resolved Hide resolved
benchmark/benchmark_generation.py Outdated Show resolved Hide resolved
benchmark/benchmark_generation.py Outdated Show resolved Hide resolved
benchmark/benchmark_generation.py Outdated Show resolved Hide resolved
src/sandbox/README.md Outdated Show resolved Hide resolved
tests/test_fused_rotary_embedding.py Outdated Show resolved Hide resolved
tests/test_fused_rotary_embedding.py Outdated Show resolved Hide resolved
tests/test_fused_rotary_embedding.py Outdated Show resolved Hide resolved
tests/test_fused_rotary_embedding.py Outdated Show resolved Hide resolved
@3outeille 3outeille force-pushed the ferdinand/fused-rotary-embedding branch 3 times, most recently from ac8fd33 to 253c70f Compare December 19, 2023 15:06
@3outeille 3outeille force-pushed the ferdinand/fused-rotary-embedding branch 4 times, most recently from 8f1a2b0 to 74e2ac8 Compare January 3, 2024 14:22
@3outeille 3outeille force-pushed the ferdinand/fused-rotary-embedding branch 8 times, most recently from 0ee5161 to 6bf98b1 Compare January 8, 2024 20:27
@3outeille 3outeille force-pushed the ferdinand/fused-rotary-embedding branch from 0838a0b to 46e4a74 Compare January 8, 2024 20:32
@3outeille 3outeille marked this pull request as ready for review January 8, 2024 20:32
NouamaneTazi
NouamaneTazi requested changes Jan 9, 2024
View reviewed changes
run_generate.py Outdated Show resolved Hide resolved
run_generate.py Outdated Show resolved Hide resolved
run_generate.py Outdated Show resolved Hide resolved
src/nanotron/generate/generation.py Outdated Show resolved Hide resolved
src/nanotron/generate/generation.py Outdated Show resolved Hide resolved
src/nanotron/models/fast/llama.py Show resolved Hide resolved
@3outeille 3outeille force-pushed the ferdinand/fused-rotary-embedding branch from 28aa183 to 16aac31 Compare January 9, 2024 10:45
NouamaneTazi
NouamaneTazi approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@NouamaneTazi NouamaneTazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment and got to merge. Thanks 🙌

run_generate.py Outdated Show resolved Hide resolved
run_generate.py Outdated Show resolved Hide resolved
@3outeille 3outeille force-pushed the ferdinand/fused-rotary-embedding branch from 16aac31 to cd75677 Compare January 9, 2024 11:29
@3outeille 3outeille merged commit 487be23 into main Jan 9, 2024
@NouamaneTazi NouamaneTazi deleted the ferdinand/fused-rotary-embedding branch January 9, 2024 11:38
jquesnelle pushed a commit to NousResearch/nanotron that referenced this pull request Jul 4, 2024
@ischlag
Merge pull request huggingface#6 from TJ-Solergibert/nanosets_and_dat…
e3ec5e3 
…atrove

Supporting datatrove tokenized documents with Nanosets
thenno added a commit to tractoai/nanotron that referenced this pull request Dec 3, 2024
@thenno
Validate tensors in dataset (huggingface#6)
29f8d11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NouamaneTazi NouamaneTazi NouamaneTazi approved these changes

@thomwolf thomwolf Awaiting requested review from thomwolf

Assignees

@3outeille 3outeille

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3outeille @NouamaneTazi