Code

New git-aware cache file layout#801

Code

Merged

LysandreJik merged 47 commits intomainhuggingface/huggingface_hub:mainfrom cache-file-layouthuggingface/huggingface_hub:cache-file-layoutCopy head branch name to clipboardMay 25, 2022

+1,037-173

Commits

Commits on May 24, 2022

• light typing

  Show description for 6fa66c4
  

  julien-c

  authored and

  LysandreJik

  committed
  6fa66c4

  Copy full SHA for 6fa66c4

• remove this seminal comment

  Show description for 29a8833
  

  julien-c

  authored and

  LysandreJik

  committed
  29a8833

  Copy full SHA for 29a8833

• I don't understand why we don't early return here

  Show description for da92022
  

  julien-c

  authored and

  LysandreJik

  committed
  da92022

  Copy full SHA for da92022

• following last commit, unnest this

  Show description for e4d3686
  

  julien-c

  authored and

  LysandreJik

  committed
  e4d3686

  Copy full SHA for e4d3686

• [BIG] This should work for all repo_types not just models!

  Show description for 8e4ccf4
  

  julien-c

  authored and

  LysandreJik

  committed
  8e4ccf4

  Copy full SHA for 8e4ccf4

• one more

  Show description for 5ab8b74
  

  julien-c

  authored and

  LysandreJik

  committed
  5ab8b74

  Copy full SHA for 5ab8b74

• forgot a repo_type and reorder code

  Show description for b8376f8
  

  julien-c

  authored and

  LysandreJik

  committed
  b8376f8

  Copy full SHA for b8376f8

• also rename this cache folder

  Show description for 4cb1d63
  

  julien-c

  authored and

  LysandreJik

  committed
  4cb1d63

  Copy full SHA for 4cb1d63

• Use hf_hub_download, will be simpler later

  Show description for f7cbe18
  

  julien-c

  authored and

  LysandreJik

  committed
  f7cbe18

  Copy full SHA for f7cbe18

• in this new version, force_filename does not make sense anymore

  Show description for ea94d43
  

  julien-c

  authored and

  LysandreJik

  committed
  ea94d43

  Copy full SHA for ea94d43

• Just inline everything inside hf_hub_download for now

  Show description for 7b92719
  

  julien-c

  authored and

  LysandreJik

  committed
  7b92719

  Copy full SHA for 7b92719

• Big prototype! it works! 🎉

  Show description for d29c90e
  

  julien-c

  authored and

  LysandreJik

  committed
  d29c90e

  Copy full SHA for d29c90e

• wip wip

  

  julien-c

  authored and

  LysandreJik

  committed
  02480fd

  Copy full SHA for 02480fd

• do not touch cached_download

  

  julien-c

  authored and

  LysandreJik

  committed
  f81885d

  Copy full SHA for f81885d

• Prompt user to upgrade to hf_hub_download

  

  julien-c

  authored and

  LysandreJik

  committed
  7fbd7a4

  Copy full SHA for 7fbd7a4

• Add a legacy_cache_layout=True to preserve old behavior, just in case

  

  julien-c

  authored and

  LysandreJik

  committed
  d1e47a1

  Copy full SHA for d1e47a1

• Create relative symlinks + add some doc

  

  julien-c

  authored and

  LysandreJik

  committed
  fc930b6

  Copy full SHA for fc930b6

• Fix behavior when no network

  

  julien-c

  authored and

  LysandreJik

  committed
  f5420ed

  Copy full SHA for f5420ed

• This test now is legacy

  

  julien-c

  authored and

  LysandreJik

  committed
  9f1e0f6

  Copy full SHA for 9f1e0f6

• Fix-ish conflict-ish

  

  julien-c

  authored and

  LysandreJik

  committed
  973913e

  Copy full SHA for 973913e

• minimize diff

  

  julien-c

  authored and

  LysandreJik

  committed
  e9fb4d4

  Copy full SHA for e9fb4d4

• refactor repo_folder_name

  

  julien-c

  authored and

  LysandreJik

  committed
  adaca46

  Copy full SHA for adaca46

• windows support + shortcut if user passes a commit hash

  

  julien-c

  authored and

  LysandreJik

  committed
  fff7e9f

  Copy full SHA for fff7e9f

• Rewrite snapshot_download and make it more robust

  

  julien-c

  authored and

  LysandreJik

  committed
  06c0ca1

  Copy full SHA for 06c0ca1

• OOops

  

  julien-c

  authored and

  LysandreJik

  committed
  e3e2485

  Copy full SHA for e3e2485

• Create example-transformers-tf.py

  

  julien-c

  authored and

  LysandreJik

  committed
  7051683

  Copy full SHA for 7051683

• Fix + add a way more complete example (running on Ubuntu)

  

  julien-c

  authored and

  LysandreJik

  committed
  84ff68d

  Copy full SHA for 84ff68d

• Apply suggestions from code review

  Show description for 11974d4
  

  3 peoplecommitted
  11974d4

  Copy full SHA for 11974d4

• Update src/huggingface_hub/file_download.py

  Show description for 73cdb46
  

  julien-c

  and

  LysandreJik

  committed
  73cdb46

  Copy full SHA for 73cdb46

• Update src/huggingface_hub/file_download.py

  Show description for 9f8b876
  

  julien-c

  and

  LysandreJik

  committed
  9f8b876

  Copy full SHA for 9f8b876

• Only allow full revision hashes otherwise the revision != commit_hash test is not reliable

  

  julien-c

  authored and

  LysandreJik

  committed
  2c5c94b

  Copy full SHA for 2c5c94b

• add a little bit more doc + consistency

  

  julien-c

  authored and

  LysandreJik

  committed
  35fff44

  Copy full SHA for 35fff44

• Update src/huggingface_hub/snapshot_download.py

  Show description for 383022f
  

  LysandreJik

  and

  patrickvonplaten

  committed
  383022f

  Copy full SHA for 383022f

• Update snapshot download

  LysandreJik

  committed
  7112146

  Copy full SHA for 7112146

• First pass on tests

  LysandreJik

  committed
  8f99d22

  Copy full SHA for 8f99d22

• Wrap up tests

  LysandreJik

  committed
  01e3a61

  Copy full SHA for 01e3a61

• 🐺 Fix for bug reported by @thomwolf

  Show description for 2d54dd1
  

  julien-c

  authored and

  LysandreJik

  committed
  2d54dd1

  Copy full SHA for 2d54dd1

• Special case for Windows

  LysandreJik

  committed
  8f71ad6

  Copy full SHA for 8f71ad6

• Address comments and docs

  LysandreJik

  committed
  442b5b1

  Copy full SHA for 442b5b1

Commits on May 25, 2022

• Clean up with ternary cc @julien-c

  LysandreJik

  committed
  e1ff4eb

  Copy full SHA for e1ff4eb

• Add argument to cached_download

  LysandreJik

  committed
  e69ef4f

  Copy full SHA for e69ef4f

• Opt-in for filename_to-url

  LysandreJik

  committed
  0d06b55

  Copy full SHA for 0d06b55

• Opt-in for filename_to-url

  LysandreJik

  committed
  d6bb92e

  Copy full SHA for d6bb92e

• Pass the flag

  LysandreJik

  committed
  4259642

  Copy full SHA for 4259642

• Update docs/source/package_reference/file_download.mdx

  Show description for a8348ab
  

  LysandreJik

  and

  sgugger

  authored
  a8348ab

  Copy full SHA for a8348ab

• Update src/huggingface_hub/file_download.py

  Show description for 8c599ee
  

  LysandreJik

  and

  sgugger

  authored
  8c599ee

  Copy full SHA for 8c599ee

• Address review comments

  LysandreJik

  committed
  3dfc00c

  Copy full SHA for 3dfc00c