-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace obsolete function argument name in docs for api.create_repo
#795
Conversation
`repo_id` does not appear to work. Is `name` the newer version?
api.create_repo
Hi @pavel-lexyr , what makes you think |
I do think it's an issue since the change has not been released but the docs were updated as in https://huggingface.co/docs/hub/adding-a-model#creating-a-repository-2 |
Ah, good catch! I wasn't aware that the docs were automatically deployed. This will change with #782 as the docs will be deployed on a version-basis to the stable docs, and the docs for |
The docs are updated when they are hub-docs sub-module is updated in moon landing |
So what's the path forward here? I don't think we want to merge this to |
@osanseviero mentioned that he would like to see the following PRs merged before the next release:
I personally would like to see #782 merged before the next release. We can either:
What do you think, @osanseviero, @adrinjalali? |
IMO none of the PRs I mentioned are release-blocking so it is ok if we do two releases so our docs are in sync. We have also done a lot of interesting work since last release, so I think we can go ahead 😄 No strong opinion though. |
I'd rather wait for those PRs (maybe except #782, since I'm not sure how much work that is. It looks like that PR's gonna take a while to be merged). I think we should have a slow-ish release cycle for this library since it's the core library used by all integrations, and the deprecation cycle should give people enough time to adapt their code. Having two releases in the span of a week doesn't give people enough time to adapt. |
SGTM! |
This can be closed as the new release was done and |
repo_id
does not appear to work. Isname
the newer version?