Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rename/transfer repo rule docs #742

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Update rename/transfer repo rule docs #742

merged 2 commits into from
Mar 8, 2022

Conversation

allendorf
Copy link
Contributor

Updated to reflect new move repo authorizations in https://github.com/huggingface/moon-landing/pull/2204 (and fixed a few typos)

- Updated to reflect new move repo authorizations (and fixed a few typos)
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs with the authorizations! I left one comment on clarifying when you can transfer a repository, otherwise everything else looks good 😊

docs/hub/main.md Outdated

Moving does not work for ❌
- Transfering a repository from an organization to another user or organization.
- Transfering a repository from user A to user B.
- Transferring a repository from an organization to another user or organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a bit confusing since the use case above says you can do an org-to-org transfer if you have the appropriate rights, but here it says you can't. I think it'd be clearer here if we explicitly say you can't do an org-to-org transfer if you aren't a member of the target organization or have the rights, instead of letting the reader infer that themselves?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! updated here: a1893e1 let me know what you think!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!!

Copy link
Member

@Pierrci Pierrci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! 👍

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good 🚀

@allendorf allendorf merged commit 3bddc88 into main Mar 8, 2022
@allendorf allendorf deleted the update-rename-docs branch March 8, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants