Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove paying subscription mention from docstring #653

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Remove paying subscription mention from docstring #653

merged 6 commits into from
Feb 22, 2022

Conversation

cakiki
Copy link
Contributor

@cakiki cakiki commented Feb 4, 2022

Private repositories do not need a paying subscription; this PR removes that from the docstring of the push_to_hub function.

cc @osanseviero

cakiki and others added 2 commits February 4, 2022 15:25
@cakiki
Remove paying subscription mention from docstring
d647221
@mishig25
Fix pasting copied text inside TextAreaWidget (huggingface#625)
df18b71 
* Fix copied text bug in span

* Add type

* Refactor

* prettier

* Use `textarea` el

* lint

* chore
osanseviero
osanseviero reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also remove this from

huggingface_hub/src/huggingface_hub/keras_mixin.py

Line 106 in 3ab328a

Whether or not the repository created should be private (requires a paying subscription).
please?

@osanseviero
Copy link
Contributor

I think that last commit might have modified an unrelated file. Would you mind removing it?

@cakiki
Copy link
Contributor Author

cakiki commented Feb 4, 2022

I have no idea how that got in there, sorry 😅

osanseviero
osanseviero approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR! 🚀

@julien-c julien-c merged commit 10bc09f into huggingface:main Feb 22, 2022
@cakiki cakiki deleted the fix-typo-push-to-hub branch February 22, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cakiki @osanseviero @julien-c @mishig25