Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the progress bars when cloning a repository #517

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Fix the progress bars when cloning a repository #517

merged 3 commits into from
Dec 14, 2021

Conversation

LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Dec 2, 2021 •
edited
Loading

The environment changes that had to happen for the GIT_LFS_SKIP_SMUDGE ended up modifying the progress bars for that specific command.

A test should be setup to ensure this doesn't happen.

@LysandreJik LysandreJik marked this pull request as ready for review December 2, 2021 12:39
osanseviero
osanseviero approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

As you mentioned a test to ensure this does not happen would be nice

@LysandreJik
Copy link
Member Author

Will merge this to have the progress bars on main and work on a test as soon as I have a bit of time.

@LysandreJik LysandreJik merged commit 94a49cc into main Dec 14, 2021
@LysandreJik LysandreJik deleted the fix-git-lfs-progress-clone branch December 14, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LysandreJik @osanseviero