Add ability to skip large files #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
reviewed
Nov 15, 2021
There was a problem hiding this comment.
Great, thanks for your PR! Left a few comments.
Please also write tests leveraging the staging endpoint, like it's already done for other Repository tests. In order to test this, please use tiny files that are sill LFS tracked (thanks to their extension, for example). You can check for the size of the file to check if the pointer was downloaded or if the full file was downloaded.
|
Needed this for another PR, will add the tests in the corresponding PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424
Started a draft to add the ability to skip large files when git cloning a repo from the hub (as I need it ASAP).
To do: