-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root methods instead of HfApi
#388
Conversation
i think this makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resulting API is so much nicer 😍
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! This goes in the right direction, things are much cleaner
This PR offers methods as root methods instead of leveraging the
HfApi
. Since theHfApi
is essentially stateless in most use-cases, there is essentially no need to add an additional layer between the user and what they want to do.This offers repository management methods at the root of
huggingface_hub
.I've updated the docs alongside it, @stevhliu I should not have forgotten anything unless I'm mistaken.
This is fully backward compatible.