Add timeout to dataset_info #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
LysandreJik
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain environments such as the Jean Zay cluster, there is no internet connection and internet requests hang indefinitely.
To be able to properly raise an error in such cases instead of making the program hang, I think it would be nice to add a
timeoutparameter toHfApi.dataset_infothat can be passed torequests.get.I added
timeouttoHfApi.dataset_infoand alsoHfApi.model_infofor consistencyClose #372
Related to the new integration of
dataset_infoindatasetsat huggingface/datasets#2986