-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth to snapshot download #340
Add auth to snapshot download #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on the implementation @lewtun, this was an oversight!
I'm not sure why the unit tests are failing since they seem to be unrelated to the changes in this PR 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: failing tests, some are unfortunately flaky at the moment :( You can try to re-run the workflows.
Code looks good to me, it would be great if you add some unit tests. You can use private
in Repository
to make a private repo. Then you could have a test without token that shows that the command fails, and another one with token that shows it works.
1f52587
to
42d3ed1
Compare
Thanks for the tips and suggestions - the new unit test should cover the three possible values of |
This reverts commit eca1e8b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks a lot
@LysandreJik this PR is ready for a final pass / approval on your side :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for iterating @lewtun!
Will do a release containing this commit later today. |
This PR adds a
use_auth_token
argument tosnapshot_download
so private repos can be downloaded from the Hub.Usage