Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SD for superb (speech-classification). #225

Merged
merged 8 commits into from
Jul 27, 2021
Merged

Adding SD for superb (speech-classification). #225

merged 8 commits into from
Jul 27, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Jul 27, 2021

  • Adding a normalizers to help reformat the tensor into a list of classes
  • Test for said normalizer (depends on torch, but it should be overall optional)
  • Add the actual pipeline within superb.
  • Will need update to api-inference-community.

@Narsil Narsil requested a review from osanseviero July 27, 2021 08:45
osanseviero
osanseviero reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Just a couple of comments

api-inference-community/api_inference_community/normalizers.py Outdated Show resolved Hide resolved
api-inference-community/docker_images/superb/app/pipelines/speech_classification.py Outdated Show resolved Hide resolved
api-inference-community/docker_images/superb/app/pipelines/speech_classification.py Outdated Show resolved Hide resolved
osanseviero
osanseviero approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Approving this since it looks good IMO.

Last thing I think we should add are unit tests (under superb/tests)

api-inference-community/docker_images/common/app/pipelines/speech_classification.py Outdated Show resolved Hide resolved
osanseviero
osanseviero approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

api-inference-community/docker_images/common/app/pipelines/speech_segmentation.py Show resolved Hide resolved
api-inference-community/tests/test_dockers.py Show resolved Hide resolved
@Narsil Narsil merged commit ac51c4f into main Jul 27, 2021
@Narsil Narsil deleted the sd_for_superb branch July 27, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Narsil @osanseviero