-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL when uploading to proxy #2167
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hi @livegoplayer I just pushed a (last?) fix: 64abc0e. This was an oversight from my side. Just for the record:
I previously forgot to distinguish the "single part" and "multi part" LFS workflows, that's why you got an error while I didn't. I only tried to upload a 1kb LFS file which has 1 step less than your 150MB file (since the 150Mb is split in chunks of 16MB). Anyway, I hope all issues are now fix. @livegoplayer could you retry and confirm? Thank you in advance 🙏 |
我测试成功了,我上传了一个很多g的文件,并且成功了 |
Yay! 🎉 |
* Fix URL when uploading to proxy * fix multi-part LFS upload
Follow-up PR after #2155 to definitively fix #2152. Thanks @livegoplayer for reporting the remaining issue in #2152 (comment). I made a mistake when trying the fix and my machine was still able to reach hf.co. This PR should settle the problem for good.
@livegoplayer would you mind trying again on your side? You can test it by installing
huggingface_hub
from this branch:You testing scripts from #2152 (comment) looks good so normally upload should correctly work. Please let me know how it goes!
cc @padeoe vor visibility