Fix ModelHubMixin
: pass config when __init__
accepts **kwargs
#2058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a breaking change introduced in #2001.
Since #2001, we fetch the config.json file in ModelHubMixin and parse the config as a dict or dataclass depending on the expected param in
__init__
. Ifconfig
is not expected, we don't pass it to_from_pretrained
(otherwise it'll brake when instantiating the class). This PR fixes this behavior by sending theconfig
value also when__init__
accepts **kwargs, which is the default when nothing is defined.cc @mfuntowicz who noticed the breaking change
Once this PR is approved and merged, I'll make a hot-fix release (0.21.3).