[FIX] Catch TypeError when parsing card data from ModelInfo #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thanks for the review @LysandreJik ! |
Wauplin
added a commit
that referenced
this pull request
Nov 13, 2023
* [FIX] Catch TypeError when parsing card data from ModelInfo * fix tests * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1817.
The problem was that for models with a corrupted model-index in their data card (i.e. created before we added the check server-side), the error was not caught if a
TypeErroris raised. We were only ignoringKeyError. This PR fixes this and adds a regression test.Thanks @ademait for reporting!
Note: this is a regression introduced by #1788. Once this is merged, I'll ship a hot-fix release as it was working correctly in
v0.18.0(since server data was not parsed into a Python object).EDIT: I also fixed 2 CardData-related tests that were broken due to server-side update.
EDIT 2: also switched from
logger.warningstowarning.warnin repocard module for consistency with the rest of the library