Added translation of 3 files as mentioned in issue #1772

aneeshd27 · 2023-10-21T07:42:01Z

Worked on Issue- #1771
Added translation of quick-start.md,installation.md and index.md and made changes in yml file.
@Wauplin can you please take a look at it ?
It would mean to lot.
Thank you.

Wauplin · 2023-10-23T10:00:53Z

Hey @aneeshd27 🤗 Thanks a lot for starting this work! 🔥 I'll definitely have a look at it yes :)

A few things I've spotted:

It's preferable to not add the pages that are not translated yet. You can either remove them from _toctree.yml which will have as an effect to redirect the user to the English version of the page. Otherwise you can also create a page "in translation" and redirect to this one instead (to let users know it's not translated yet. My fear with adding duplicated English pages is that we lose track of which files are translated and which ones aren't (and also would need duplicated work when updating the English docs). Here is an example of how it has been done in the Korean documentation.
The package_reference section can be removed IMO. This is not a section that can be translated given that it is 90% auto-generated content from the function docstrings (which are hard-coded in English). The translated documentation should focus more on the how-to guides themselves.
A nice addition if you have the time would be to translate the README as well (example here for German). Since this is the entry-point for the Github repository, it is good to have it translated so that Hindi-speaking users can directly see that some content is dedicated to their language. If you prefer, this can also be done in a future PR.
Finally, the build_pr_documentation.yml and build_documentation.yml have to be updated so that Hindi documentation are generated as well by the CI. You just need to update the language line by languages: en de hi ko in both files.

And I think that's it from a technical point of view. About the Hindi content itself I'll ping some members from the Hindi-speaking community to review 🤗 Thanks again for the hard work!

Vaibhavs10

Very cool! Thanks for beginning translation work! <3

There are some inconsistencies in the translation:

IMO, whenever we mention the package then, it should be mentioned as huggingface_hub
Next, let's make sure that all the URLs work, some URLs are in Hindi and the others in English, do make sure to test this.

happy to re-review after you take a pass.

docs/source/hi/index.md

docs/source/hi/installation.md

Added hindi translation in file to avoid redirects for non-translated files

Added Hindi Translation for README file

Added hi-ISO 639 code in yaml file

Added hi code in file

Added the changes mentioned in code review

Made the required changes mentioned in the code review

Corrected a typo

aneeshd27 · 2023-10-23T17:08:19Z

@Wauplin I have made the necessary changes as mentioned before review.
@Vaibhavs10 I have made the required changes as mentioned during review like replace translated library into English.
It would be great if you take a look at it.
Thank you,
Aneesh.
😄

Issue: #1771
Pull Request: #1772

Wauplin

Thanks for making the changes to the workflow files and incorporating feedback from the previous review. I left a few new comments about files that are not necessary yet. We will add them iteratively in future PRs.

Thank you also for translating the README.md file! That's a very important one to get started. @Vaibhavs10 would you mind taking a look at it?

@aneeshd27 most of my comments are about setting up the translated docs for the first time. I promise that next PRs will be much easier to write :)

docs/source/hi/_redirects.yml

docs/source/hi/_toctree.yml

README_hi.md

Delete redirects.yml as mentioned during review

Updated _toctree.yml Removed all the Hindi translation that have not been done yet.Have kept the english translation for redirection

Changed the order to en de hi ko

Added translation link of README_hi.md in file

Added translation links of Korean files as mentioned in review

Updated file

aneeshd27 · 2023-10-24T13:36:32Z

Made Changes as mentioned in Review 2 of the branch aneeshd27-translation

Vaibhavs10

The README looks good to me! Great job!

README_hi.md

Updated the suggested changes

Updated the changes

aneeshd27 · 2023-10-24T15:02:46Z

Updated the necessary changes as mentioned in the review.
@Vaibhavs10 Can you please take a look at it?
Thank you,
Aneesh 😄

Added only necessary changes in file

aneeshd27 · 2023-10-25T17:20:56Z

I have made the told changes as mentioned in the review.
@Wauplin Can you please take a look at it?
Thank you,
Aneesh 😄

Wauplin

Thanks for making the changes @aneeshd27! I think the last thing to change from a technical point of view is to remove all guides/concepts pages from this PR. The goal is that only Hindi-written pages are added in the PR, nothing else.
Thank you in advance!
Wauplin

README_hi.md

Wauplin · 2023-10-26T07:39:54Z

docs/source/hi/concepts/git_vs_http.md

@@ -0,0 +1,62 @@
+<!--⚠️ Note that this file is in Markdown but contain specific syntax for our doc-builder (similar to MDX) that may not be


Since this file is not translated and not referenced in the toctree, can you remove it from the PR?
(same for all files in /concepts and /guides)

Wauplin · 2023-10-26T07:40:42Z

docs/source/hi/in_translation.md

@@ -0,0 +1,5 @@
+<!--⚠️ Note that this file is in Markdown but contain specific syntax for our doc-builder (similar to MDX) that may not be


In the end this file can be removed as it is not referenced anywhere.

aneeshd27 · 2023-10-26T08:37:45Z

I have made all the changes like deleting files from concepts and guides folder which have not been translated.
@Wauplin Can you please check if the right changes have been made?
Thank you,
Aneesh 😄

Wauplin

Perfect! Everything looks good now! Thanks for the additional changes 🙏

~~@Vaibhavs10 would you like to make a last review or are we good to merge?~~
EDIT: I just realized you already reviewed the README as well. Will merge then :)

HuggingFaceDocBuilderDev · 2023-10-26T12:30:21Z

The documentation is not available anymore as the PR was closed or merged.

Added translation of 3 files as mentioned in issue

3559892

Vaibhavs10 self-assigned this Oct 23, 2023

Vaibhavs10 reviewed Oct 23, 2023

View reviewed changes

aneeshd27 added 9 commits October 23, 2023 21:48

Create in_translation.md

30adda6

Added hindi translation in file to avoid redirects for non-translated files

Create README_hi.md

ed322de

Added Hindi Translation for README file

Update build_documentation.yaml for Hindi(hi)

497e5b7

Added hi-ISO 639 code in yaml file

Update build_pr_documentation.yaml

10f8b38

Added hi code in file

Update build_documentation.yaml

1c6383b

Update index.md

89a34ee

Added the changes mentioned in code review

Update installation.md in hi

95fa2ca

Made the required changes mentioned in the code review

Update quick-start.md

be59697

Corrected a typo

Delete docs/source/hi/package_reference directory

8bb5292

Merge branch 'main' into aneeshd27-translation

b522212

Wauplin reviewed Oct 24, 2023

View reviewed changes

docs/source/hi/_redirects.yml Outdated Show resolved Hide resolved

docs/source/hi/_toctree.yml Outdated Show resolved Hide resolved

docs/source/hi/_toctree.yml Outdated Show resolved Hide resolved

README_hi.md Outdated Show resolved Hide resolved

aneeshd27 added 9 commits October 24, 2023 18:39

Delete docs/source/hi/_redirects.yml

c8bd5ef

Delete redirects.yml as mentioned during review

Update _toctree.yml

b5adf5d

Updated _toctree.yml Removed all the Hindi translation that have not been done yet.Have kept the english translation for redirection

Update README_hi.md

f7fdbde

Changed the order to en de hi ko

Update README.md

729241f

Added translation link of README_hi.md in file

Update README.md

07b7857

Update README.md

cabfe97

Update README_de.md

1e4d45b

Added translation links of Korean files as mentioned in review

Update README_de.md

fe9952d

Update README_ko.md

92ef359

Updated file

Vaibhavs10 approved these changes Oct 24, 2023

View reviewed changes

README_hi.md Outdated Show resolved Hide resolved

aneeshd27 added 2 commits October 24, 2023 20:26

Update README_hi.md

4c72fe3

Updated the suggested changes

Update README_hi.md

2d87b97

Updated the changes

aneeshd27 added 5 commits October 25, 2023 22:39

Update _toctree.yml

3e82f5b

Added only necessary changes in file

Update README.md

9adb7cd

Update README_de.md

8deab90

Update README_ko.md

74c7017

Update README_hi.md

5e01875

aneeshd27 and others added 2 commits October 25, 2023 22:53

Merge branch 'main' into aneeshd27-translation

732f33e

Update docs/source/hi/_toctree.yml

c4ebc34

Wauplin reviewed Oct 26, 2023

View reviewed changes

Wauplin and others added 5 commits October 26, 2023 09:43

Update README_hi.md

f784de3

Delete docs/source/hi/concepts directory

6dc8ddb

Delete docs/source/hi/in_translation.md

803cafa

Delete docs/source/hi/guides directory

96bd75d

Merge branch 'main' into aneeshd27-translation

38a95dc

Wauplin approved these changes Oct 26, 2023

View reviewed changes

Wauplin merged commit b3e06ae into huggingface:main Oct 26, 2023

Wauplin mentioned this pull request Oct 26, 2023

[i18n-HI] Translating docs to Hindi #1771

Open

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added translation of 3 files as mentioned in issue #1772

Added translation of 3 files as mentioned in issue #1772

aneeshd27 commented Oct 21, 2023 •

edited

Loading

Wauplin commented Oct 23, 2023

Vaibhavs10 left a comment

aneeshd27 commented Oct 23, 2023 •

edited

Loading

Wauplin left a comment

aneeshd27 commented Oct 24, 2023

Vaibhavs10 left a comment

aneeshd27 commented Oct 24, 2023

aneeshd27 commented Oct 25, 2023

Wauplin left a comment

Wauplin Oct 26, 2023

Wauplin Oct 26, 2023

aneeshd27 commented Oct 26, 2023

Wauplin left a comment •

edited

Loading

HuggingFaceDocBuilderDev commented Oct 26, 2023 •

edited

Loading

		@@ -0,0 +1,62 @@
		<!--⚠️ Note that this file is in Markdown but contain specific syntax for our doc-builder (similar to MDX) that may not be

		@@ -0,0 +1,5 @@
		<!--⚠️ Note that this file is in Markdown but contain specific syntax for our doc-builder (similar to MDX) that may not be

Added translation of 3 files as mentioned in issue #1772

Added translation of 3 files as mentioned in issue #1772

Conversation

aneeshd27 commented Oct 21, 2023 • edited Loading

Wauplin commented Oct 23, 2023

Vaibhavs10 left a comment

Choose a reason for hiding this comment

aneeshd27 commented Oct 23, 2023 • edited Loading

Wauplin left a comment

Choose a reason for hiding this comment

aneeshd27 commented Oct 24, 2023

Vaibhavs10 left a comment

Choose a reason for hiding this comment

aneeshd27 commented Oct 24, 2023

aneeshd27 commented Oct 25, 2023

Wauplin left a comment

Choose a reason for hiding this comment

Wauplin Oct 26, 2023

Choose a reason for hiding this comment

Wauplin Oct 26, 2023

Choose a reason for hiding this comment

aneeshd27 commented Oct 26, 2023

Wauplin left a comment • edited Loading

Choose a reason for hiding this comment

HuggingFaceDocBuilderDev commented Oct 26, 2023 • edited Loading

aneeshd27 commented Oct 21, 2023 •

edited

Loading

aneeshd27 commented Oct 23, 2023 •

edited

Loading

Wauplin left a comment •

edited

Loading

HuggingFaceDocBuilderDev commented Oct 26, 2023 •

edited

Loading