Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidated mypy type ignores in InferenceClient.post #1742

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Consolidated mypy type ignores in InferenceClient.post #1742

merged 2 commits into from
Oct 16, 2023

Conversation

jamesbraza
Copy link
Contributor

See PR title

@jamesbraza
Copy link
Contributor Author

@Wauplin can you help with CI error? I think make style is wrong here

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 13, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@Wauplin
Copy link
Contributor

Wauplin commented Oct 16, 2023

@Wauplin can you help with CI error? I think make style is wrong here

Yes true, it is because of the code generating the async inference client. Should be fixed by f9f241b

Wauplin
Wauplin approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

@Wauplin Wauplin merged commit 99040ec into huggingface:main Oct 16, 2023
@jamesbraza jamesbraza deleted the mypy-type-ignore-fix branch October 16, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesbraza @HuggingFaceDocBuilderDev @Wauplin