Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move repo size limitations to Hub docs #1660

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 12, 2023

Related to huggingface/hub-docs#949 (and internal slack thread)

The Hub repository size limitations section of the docs is not huggingface_hub-specific. This PR removes this section from these docs and links to the main Hub docs instead. To be merged once huggingface/hub-docs#949 is merged.

@Wauplin Wauplin added the documentation Improvements or additions to documentation label Sep 12, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 12, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-c
Copy link
Member

are we sure we don't want to also have a summary here? (no strong opinion)

LGTM otherwise

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏

docs/source/en/guides/upload.md Outdated Show resolved Hide resolved
@Wauplin
Copy link
Contributor Author

Wauplin commented Sep 12, 2023

are we sure we don't want to also have a summary here? (no strong opinion)

Let's keep it as it is now (just a link). It should be enough.

Thanks for the reviews. Now that huggingface/hub-docs#949 has been merged and is live, let's merge this one as well.

@Wauplin Wauplin merged commit 49cbeb7 into main Sep 12, 2023
@Wauplin Wauplin deleted the move-repo-limitations-docs-to-hf-hub branch September 12, 2023 15:27
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants