Added support for secret description #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks for taking care of this @martinbrose ! I've added a comment about empty strings vs None values. Otherwise PR looks good to me. Thanks for taking care of documentation + tests!
Wauplin
approved these changes
Aug 16, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
|
Some errors in the CI but not related to your work @martinbrose. Merging this one right now. Great job! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
secrets's description #1556