Retry on both ConnectTimeout and ReadTimeout #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
===========================================
+ Coverage 51.14% 82.23% +31.08%
===========================================
Files 57 57
Lines 6106 6106
===========================================
+ Hits 3123 5021 +1898
+ Misses 2983 1085 -1898
☔ View full report in Codecov by Sentry. |
LysandreJik
approved these changes
Jun 26, 2023
|
Thanks for the review @LysandreJik ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1526 (cc @alexmojaki). Issue caused CI failures in huggingface/transformers#24384 (comment) (cc @ydshieh).
At the moment HTTP requests failing with a
ConnectTimeoutorProxyErrorwhen downloading a file are retried with a backoff strategy. This PR addsReadTimeoutas an exception to retry on as well. More precisely, we now retry on anyrequests.exceptions.Timeouterror (meaning both connect and read timeouts).This change does not introduce a breaking change as
ConnectTimeouterrors are still caught. It should fix downloads in some rare occasions.