Add x-request-id to every request #1518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a suggestion from @XciD, this PR adds a custom
x-request-id
header in all calls made to the Hub. The request id is unique (uuid4()
) and changes in each http call. The idea is to help debugging issues even when a 504 Gateway timeout is raised. At the moment, if the request id is created server-side but a 504 happens, the request id is not sent back to the client, making it much harder to track the issue in our logs.cc @Pierrci @julien-c this shouldn't change anything for moon-landing
(I've also added a local debug log to help with it)