Set 30s timeout on downloads (instead of 10s) #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
approved these changes
Jun 16, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
julien-c
reviewed
Jun 16, 2023
src/huggingface_hub/file_download.py
Outdated
| How many seconds to wait for the server to send data before | ||
| giving up which is passed to `requests.request`. | ||
| giving up which is passed to `requests.request`. Defaults to no timeouts. |
There was a problem hiding this comment.
hmm there's still a timeout no? just controlled by the server...
I would default to 30s maybe
There was a problem hiding this comment.
Cloudfront is defaulting at 60s. I can update the docstring.
There was a problem hiding this comment.
i don't see the drawback of having a value on the client side honestly
There was a problem hiding this comment.
Ok, let's put 30s then. I don't see a good reason to put a value either but I'm fine with it
There was a problem hiding this comment.
Reverted to 30s timeout in 8e16055
There was a problem hiding this comment.
code determinism if/when the server config changes
Wauplin
changed the title
|
Let's merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to internal slack thread. The default timeout when downloading a file (
hf_hub_download) is 10s. This is far enough in most cases but in a very few cases it causes a ConnectionError (especially intransformers's CI recently). Except if this 10s limit is really useful, I suggest to remove it. In the worst case, there is a 60s timeout on cloudfront.Note: I am not talking about the 10s
etag_timeoutthat is used when making the HEAD call to the file. For this one I think it's good to keep it and default early (10s) to the local cache.Thanks @ydshieh @rtrompier for debugging this one! I hope it'll solve transformers's issues :)
@julien-c @Pierrci @LysandreJik since it's about the
/resolve/endpoint, please let me know your opinion on this one 🙏EDIT: reverted to 30s in 8e16055 (see #1514 (comment))