Fix consistency check when downloading a file #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Wauplin
changed the title
LysandreJik
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the recent release of
huggingface_hub==0.14.0. See huggingface/diffusers#3213 raised indiffusers. The problem happens when downloading a script from Github. Due to compression theContent-Lengthheader is smaller than the actual file size (hence raising an exception). Consistency check was added in #1403.To fix it I forbid compression on the HEAD call (
headers["Accept-Encoding"] = "identity") to retrieve the correct file size before making the correct GET call. Cc @julien-c @XciD this means that adding compression on the Hub will not mess with file metadata retrieval (it was the case before)