Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReprMixin for python3.7 + test #1380

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 8, 2023

sort_dicts is not supported in Python 3.7. Let's remove it (not so problematic IMO if keys are sorted).

Has been reported by transformers CI when testing the pre-release.

cc @davanstrien

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 8, 2023

The documentation is not available anymore as the PR was closed or merged.

@Wauplin Wauplin merged commit bf0f208 into main Mar 8, 2023
@Wauplin Wauplin deleted the hot-fix-repr-mixin-python3.7 branch March 8, 2023 11:36
@davanstrien
Copy link
Member

sort_dicts is not supported in Python 3.7. Let's remove it (not so problematic IMO if keys are sorted).

Has been reported by transformers CI when testing the pre-release.

cc @davanstrien

Good catch, thanks for fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants