-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates types for RepoCards fields #1358
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Hi @davanstrien , thanks for taking the time.
Yes I think it makes sense to keep the type |
i think the current PR is good! (i was not sure about languages either, but i think it's fine to type it as str[]) |
Fine with keeping the PR as is it as well, was just asking. |
Thanks both; I'll do a quick double-check for any other changes tomorrow am. I'll update the PR to ready for review once I've done that. |
I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'm merging it :)
Follows up from #1356 to update more repo card attribute types to
Optional[List[str]]
.@Wauplin @julien-c, at the moment, I have changed the types for:
For some attributes like
license
, it's likely that it will almost only be a single string: should I also change those types or focus only on the fields more likely to be an array with multiple items?