Compute sha by chunks when uploading #1296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1294 (thanks @wfjsw).
When computing the sha of a file (before uploading it), the
chunksize
was defined but never used. Therefore the file was entirely loaded in memory which is problematic for huge files. This PR solves that.I also refactored it to make it "more readable". I tested it quickly on my machine and found out that a chunksize of 1MB seems optimal is term of performance (very rough estimation) and still ok in term of memory footprint.