Progress bar when uploading LFS files #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
❤️❤️❤️ :) |
LysandreJik
approved these changes
Dec 14, 2022
src/huggingface_hub/_commit_api.py
Outdated
| """ | ||
| A context manager that yields a file-like object allowing to read the underlying | ||
| data behind `path_or_fileobj`. | ||
|
|
||
| Args: | ||
| with_tqdm (bool, *optional*): |
There was a problem hiding this comment.
I think the convention is to have defaults to False, no?
There was a problem hiding this comment.
Still don't know about that. I'm seing a lot of private (bool, *optional*, defaults to False): so I'll put that.
I remember a conversation about that on Slack, wasn't so clear what the output is though 😕
|
Thanks for the review @LysandreJik :) I've adapted the docstring and will merge. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1244 (cc @sijunhe).
Add 2 progress bars when creating a commit. A "main" one showing how much LFS files must be uploaded + 1 progress for each individual LFS file. Progress bars can be disabled by setting
HF_HUB_DISABLE_PROGRESS_BARS=1as environment variable. Example:I based the implementation on @julien-c 's implementation from
transformersback in 2019 (huggingface/transformers#2078).I kept it as minimal as possible. Especially, only files that are passed as a filepath have a progress bar. Should cover 95% of the cases. I'm not against making it more flexible but it could bring more problems/corner cases to debug.
Also refactored the code to upload files in parallel (now using
thread_map).