Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing tests related to DatasetFilter #1251

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Dec 8, 2022

Related to #1250.

For now and until we fix that, let's skip the failing tests. It's annoying in CI checks.

@Wauplin Wauplin mentioned this pull request Dec 8, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 8, 2022

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 57.82% // Head: 83.92% // Increases project coverage by +26.10% 🎉

Coverage data is based on head (7eaa0e2) compared to base (f49e9da).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1251       +/-   ##
===========================================
+ Coverage   57.82%   83.92%   +26.10%     
===========================================
  Files          44       44               
  Lines        4386     4386               
===========================================
+ Hits         2536     3681     +1145     
+ Misses       1850      705     -1145     
Impacted Files Coverage Δ
src/huggingface_hub/repository.py 79.52% <0.00%> (+0.85%) ⬆️
src/huggingface_hub/utils/_runtime.py 62.50% <0.00%> (+4.80%) ⬆️
src/huggingface_hub/utils/_chunk_utils.py 100.00% <0.00%> (+7.14%) ⬆️
src/huggingface_hub/_commit_api.py 92.68% <0.00%> (+8.53%) ⬆️
src/huggingface_hub/utils/_deprecation.py 95.55% <0.00%> (+10.00%) ⬆️
src/huggingface_hub/utils/_hf_folder.py 100.00% <0.00%> (+13.15%) ⬆️
src/huggingface_hub/utils/_validators.py 100.00% <0.00%> (+13.63%) ⬆️
src/huggingface_hub/community.py 91.35% <0.00%> (+17.28%) ⬆️
src/huggingface_hub/utils/_headers.py 100.00% <0.00%> (+17.30%) ⬆️
src/huggingface_hub/_snapshot_download.py 96.42% <0.00%> (+19.64%) ⬆️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin
Copy link
Contributor Author

Wauplin commented Dec 8, 2022

Thanks for the quick review @LysandreJik :)

@Wauplin Wauplin merged commit 13058a8 into main Dec 8, 2022
@Wauplin Wauplin deleted the skip-failing-dataset-tag-tests-in-ci branch December 8, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants