Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX url encoding in hf_hub_url #1164

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Nov 7, 2022

Fix #1161. Bug doesn't seem to be elsewhere than in hf_hub_url itself.
Added 2 regression tests just to be sure.

cc @philschmid thanks for reporting it :)

(just wondering for myself: who really thought it was a good idea to have a ? in a filename ??? 😄)

@Wauplin Wauplin requested a review from LysandreJik November 7, 2022 17:03
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 7, 2022

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 84.57% // Head: 84.62% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (7fe264c) compared to base (9ccdf02).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   84.57%   84.62%   +0.04%     
==========================================
  Files          42       42              
  Lines        4182     4182              
==========================================
+ Hits         3537     3539       +2     
+ Misses        645      643       -2     
Impacted Files Coverage Δ
src/huggingface_hub/file_download.py 88.48% <ø> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin Wauplin merged commit b0e441e into main Nov 7, 2022
@Wauplin Wauplin deleted the 1161-fix-url-encoding-in-hf-hub-url branch November 7, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filename must be url encoded in hf_hub_url (and maybe elsewhere)
3 participants