feature extraction, sentence similarity and text classification now use pipeline url #197
Conversation
There was a problem hiding this comment.
Thanks, that's a neat feature!
I would add a pipeline optional string param here:
And do the logic of changing the url in makeRequestOptions instead.
In textClassification etc, it would be a one-line-change:
const res = (await request<TextClassificationOutput[]>(args, {
...options,
pipeline: "text-classification" // HERE!
}))?.[0];
|
Done changes sugested by coyotte508 |
| function isModelTypeURL(model: string): boolean { | ||
| return /^http(s?):/.test(model) || model.startsWith("/"); | ||
| } | ||
|
|
||
| function getPipelineURL(model: string, pipeline: string): string { | ||
| return `${HF_INFERENCE_API_PIPELINE_BASE_URL}${pipeline}/${model}`; | ||
| } | ||
|
|
||
| function getDefaultModelTaskURL(model: string) { | ||
| return `${HF_INFERENCE_API_MODEL_BASE_URL}${model}`; | ||
| } |
There was a problem hiding this comment.
Those are one-line local functions used once, can you hardcode them directly in makeRequestOptions?
| @@ -2,6 +2,8 @@ import { InferenceOutputError } from "../../lib/InferenceOutputError"; | |||
| import type { BaseArgs, Options } from "../../types"; | |||
| import { request } from "../custom/request"; | |||
|
|
|||
| const HF_INFERENCE_API_PIPELINE_FEATURE_EXTRACTION = "feature-extraction"; | |||
There was a problem hiding this comment.
The constant is only used once / not worth exporting, can you hardcode it below and remove the declaration here?
(maybe later we'll type pipeline as "feature-extraction" | ... | string to offer some kind of completion)
Same remark for the two other tasks
There was a problem hiding this comment.
would be interested in @Narsil (and @OlivierDehaene) feedback and maybe @Wauplin too on this
is this a feature of the Inference API we want to expose?
it's a very needed inference api feature, because many models can be used for more than one task |
|
As stated here, we might not use it in the end. |
|
Sorry @lisandropuzzolo wrong git manipulation 😬 |
Some models allows them to be use on more than one (default task).
In order to let the huggingface.js use more than the default model task, I've changed featureExtraction, sentenceSimilarity and textClassification to change the model to the pipeline url when model is not a url.