Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant prepare_module #2597

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Remove redundant prepare_module #2597

merged 2 commits into from
Jul 7, 2021

Conversation

albertvillanova
Copy link
Member

I have noticed that after implementing load_dataset_builder (#2500), there is a redundant call to prepare_module.

@albertvillanova albertvillanova added the refactoring Restructuring existing code without changing its external behavior label Jul 6, 2021
@albertvillanova albertvillanova marked this pull request as ready for review July 6, 2021 14:13
lhoestq
lhoestq approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lhoestq lhoestq merged commit 5ef78ed into huggingface:master Jul 7, 2021
@albertvillanova albertvillanova added this to the 1.10 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
refactoring Restructuring existing code without changing its external behavior
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvillanova @lhoestq