Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated user permissions based on umask #2157

Merged
merged 3 commits into from
Apr 6, 2021
Merged

updated user permissions based on umask #2157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4660f6a
updated user permissions based on umask
bhavitvyamalik Mar 31, 2021
5a7e73f
make style
bhavitvyamalik Mar 31, 2021
8eb66f8
removed umask(0)
bhavitvyamalik Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1645,7 +1645,9 @@ def init_buffer_and_writer():
if update_data and tmp_file is not None:
tmp_file.close()
shutil.move(tmp_file.name, cache_file_name)
os.chmod(cache_file_name, 0o644)
umask = os.umask(0o666)
os.umask(umask)
os.chmod(cache_file_name, 0o666 & ~umask)

if update_data:
# Create new Dataset from buffer or file
Expand Down Expand Up @@ -1884,7 +1886,9 @@ def select(
if tmp_file is not None:
tmp_file.close()
shutil.move(tmp_file.name, indices_cache_file_name)
os.chmod(indices_cache_file_name, 0o644)
umask = os.umask(0o666)
os.umask(umask)
os.chmod(indices_cache_file_name, 0o666 & ~umask)

# Return new Dataset object
if buf_writer is None:
Expand Down