Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial on proper benchmarking #734

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Add a tutorial on proper benchmarking #734

merged 3 commits into from
Oct 3, 2022

Conversation

muellerzr
Copy link
Collaborator

Given we've had so many issues about this topic, this adds a concept guide on the subject. Let me know if I seem to have missed any, but these are the main three I've observed

#526 #59 (comment)

@muellerzr muellerzr added the documentation Improvements or additions to documentation label Oct 3, 2022
@muellerzr muellerzr requested a review from sgugger October 3, 2022 16:43
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 3, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this!

docs/source/concept_guides/performance.mdx Outdated Show resolved Hide resolved
docs/source/concept_guides/performance.mdx Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit 9eb9aee into main Oct 3, 2022
@muellerzr muellerzr deleted the doc-tutorial-repro branch October 3, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants