Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override DeepSpeed grad_acc_steps from accelerator obj #698

Merged
merged 2 commits into from
Sep 14, 2022
Merged

override DeepSpeed grad_acc_steps from accelerator obj #698

merged 2 commits into from
Sep 14, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Override DeepSpeed grad_acc_steps from accelerator obj when they aren't same.

@pacman100 pacman100 requested a review from sgugger September 14, 2022 06:24
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 14, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

src/accelerate/accelerator.py Outdated Show resolved Hide resolved
@pacman100 pacman100 merged commit 1044c30 into huggingface:main Sep 14, 2022
@pacman100 pacman100 deleted the smangrul/deepspeed-grad-acc-steps-fix branch September 14, 2022 19:07
@acforvs acforvs mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger