Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix #683

Merged
merged 1 commit into from
Sep 6, 2022
Merged

🐛 fix #683

merged 1 commit into from
Sep 6, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. PR deepspeed enhancements and fixes #676 introduced 🐛 and resulted in DeepSpeed tests failing on hosted GPU runners. This PR fixes it as seen below

Screenshot 2022-09-06 at 9 24 54 PM

@pacman100 pacman100 requested a review from sgugger September 6, 2022 15:55
sgugger
sgugger approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie!
Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 6, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@pacman100 pacman100 merged commit c69659c into huggingface:main Sep 6, 2022
@pacman100 pacman100 deleted the smangrul/fix-deepspeed-bug branch September 6, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger