Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small nits to grad accum docs #656

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Small nits to grad accum docs #656

merged 2 commits into from
Aug 26, 2022

Conversation

muellerzr
Copy link
Collaborator

Emphases more on how you should use either of the two API's we provide, and links to the grad synchronization tutorial at the end of the grad accum to advertise learning about the magic it wraps around

@muellerzr muellerzr added the documentation Improvements or additions to documentation label Aug 24, 2022
@muellerzr muellerzr requested a review from pacman100 August 24, 2022 17:58
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 😄! Left a nit for more clarity.

docs/source/concept_guides/gradient_synchronization.mdx Outdated Show resolved Hide resolved
Co-authored-by: Sourab Mangrulkar <[email protected]>
@muellerzr muellerzr merged commit d0f5f4a into main Aug 26, 2022
@muellerzr muellerzr deleted the grad-accum-docs branch August 26, 2022 10:22
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants