Add static_graph arg to DistributedDataParallelKwargs. #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supported by https://pytorch.org/docs/stable/generated/torch.nn.parallel.DistributedDataParallel.html This is particularly useful when using gradient checkpointing See https://discuss.pytorch.org/t/ddp-and-gradient-checkpointing/132244/3 for more details
This was referenced Aug 15, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thanks! Could we add a warning to this please similar to the other one that exists for these kwargs in the docstring mentioning its only available on pytorch>=1.11? |
|
Sure, done |
|
@rom1504 looks like the last thing we need is to run |
|
@muellerzr fixed |
|
Great! Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported by https://pytorch.org/docs/stable/generated/torch.nn.parallel.DistributedDataParallel.html
This is particularly useful when using gradient checkpointing
See https://discuss.pytorch.org/t/ddp-and-gradient-checkpointing/132244/3 for more details