Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M1 mps fixes #625

Merged
merged 2 commits into from
Aug 11, 2022
Merged

M1 mps fixes #625

merged 2 commits into from
Aug 11, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. setting env variable "PYTORCH_ENABLE_MPS_FALLBACK" = "1" when using mps
  2. Warning which strongly recommends users to use PyTorch nightly (1.13.dev...) as per the issue [Apple Silicon M1 MPS device] bad performance metrics for BERT model training pytorch/pytorch#82707

@pacman100 pacman100 requested a review from sgugger August 11, 2022 05:11
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 11, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

src/accelerate/state.py Outdated Show resolved Hide resolved
@pacman100 @sgugger
Update src/accelerate/state.py
98068bd 
Co-authored-by: Sylvain Gugger <[email protected]>
@pacman100 pacman100 merged commit 92341b6 into huggingface:main Aug 11, 2022
@pacman100 pacman100 deleted the smangrul/mps-fixes branch August 26, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger