Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tqdm helper #564

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Add a tqdm helper #564

merged 7 commits into from
Jul 26, 2022

Conversation

muellerzr
Copy link
Collaborator

Creates a tqdm helper that will automatically only show on the main process, avoiding the need to use a if accelerator.is_local_main_process each time

@muellerzr muellerzr added the enhancement New feature or request label Jul 25, 2022
@muellerzr muellerzr requested a review from sgugger July 25, 2022 14:51
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 25, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, let's just wrap the dep to not be a core dep, just a soft dep (and the utils function tqdm then raises an ImportError if tqdm is not installed). Thanks!

setup.py Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit e3642a4 into main Jul 26, 2022
@muellerzr muellerzr deleted the utils branch July 26, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger