Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepspeed version 0.6.7 fix #544

Merged
merged 5 commits into from
Jul 22, 2022
Merged

deepspeed version 0.6.7 fix #544

merged 5 commits into from
Jul 22, 2022

Conversation

pacman100
Copy link
Contributor

@pacman100 pacman100 commented Jul 21, 2022 •
edited
Loading

What does this PR do?

  1. DeepSpeed integration is broken when using the latest deepspeed 0.6.7 version. This PR fixes it.

Tracking in accelerate with issue #536

@pacman100 pacman100 requested review from muellerzr and sgugger July 21, 2022 12:31
muellerzr
muellerzr approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Might be worth keeping an issue open about this until its resolved to send people to as they get issues/they can find it easily

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 21, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

setup.py Outdated Show resolved Hide resolved
sgugger
sgugger approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to actually fix the root of the issue!

src/accelerate/state.py Show resolved Hide resolved
muellerzr
muellerzr approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@pacman100 pacman100 changed the title deepspeed version hotfix deepspeed version 0.6.7 fix Jul 22, 2022
@pacman100 pacman100 mentioned this pull request Jul 22, 2022
Closed
@pacman100 pacman100 merged commit e98dc22 into huggingface:main Jul 22, 2022
@pacman100 pacman100 deleted the smangrul/deepspeed-test-hotfix branch July 27, 2022 04:20
@jeffra jeffra mentioned this pull request Aug 16, 2022
Merged
@pacman100 pacman100 mentioned this pull request Mar 2, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @sgugger