Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for downcasting bf16 on TPUs #523

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Add support for downcasting bf16 on TPUs #523

merged 7 commits into from
Jul 20, 2022

Conversation

muellerzr
Copy link
Collaborator

This PR adds downcasting support for bf16 on TPUs. Per the XLA docs:

  • By default both torch.float and torch.double are torch.float on TPUs.
  • If XLA_USE_BF16 is set, then torch.float and torch.double are both bfloat16 on TPUs.
  • If XLA_DOWNCAST_BF16 is set, then torch.float is bfloat16 on TPUs and torch.double is float32 on TPUs.

@muellerzr muellerzr added enhancement New feature or request TPU Bug or feature on TPU platforms labels Jul 15, 2022
@muellerzr muellerzr requested a review from sgugger July 15, 2022 09:52
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 15, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger reviewed Jul 15, 2022
View reviewed changes
src/accelerate/accelerator.py Outdated Show resolved Hide resolved
src/accelerate/accelerator.py Outdated Show resolved Hide resolved
@muellerzr muellerzr requested a review from sgugger July 19, 2022 17:34
sgugger
sgugger approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, thanks!

@muellerzr muellerzr merged commit 158acdd into main Jul 20, 2022
@muellerzr muellerzr deleted the downcast branch July 20, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request TPU Bug or feature on TPU platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger