Fixup all example CI tests and properly fail #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jul 13, 2022
| @@ -229,20 +229,14 @@ def training_function(config, args): | |||
| with torch.no_grad(): | |||
| outputs = model(**batch) | |||
| predictions = outputs.logits | |||
| predictions, references = accelerator.gather((predictions, batch["labels"])) | |||
There was a problem hiding this comment.
This will stop working on distributed setup. The predictions will need to be gathered (maybe not the labels).
There was a problem hiding this comment.
Should be fixed now
|
All slow ci is now passing here: https://github.com/huggingface/accelerate/runs/7358153325 |
sgugger
approved these changes
Jul 15, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all example CI
What does this add?
This pr makes a variety of fixes to the example tests to solve all failures and properly ensure that failures occur when they need to
Why is it needed?
The entire list of issues I noticed are below:
CometMLTrackerto run offline tests with the tracking example script, so the CI now explicitly uninstalls themrequires_trackingdecorator for the example tests to make sure at least one tracking API is installed andcomet_mlis not installedrun_commandfunction which will properly call a subprocess test function and check its outputs properly as well as fully fail if the call did not work.