Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gradient accumulation work with dispatched dataloaders #510

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

muellerzr
Copy link
Collaborator

This PR implements gradient accumulation support for dispatched dataloaders and rewrites the tests for testing all combinations of dispatched dataloaders + split batches

@muellerzr muellerzr added the enhancement New feature or request label Jul 12, 2022
@muellerzr muellerzr requested a review from sgugger July 12, 2022 14:57
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 12, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot for working on this!

src/accelerate/test_utils/scripts/test_sync.py Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit c7526e9 into main Jul 12, 2022
@muellerzr muellerzr deleted the streamable-datasets-good branch July 12, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants