Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docbuilder to setup.py #468

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add docbuilder to setup.py #468

merged 1 commit into from
Jun 23, 2022

Conversation

muellerzr
Copy link
Collaborator

Adds docbuilder to the setup.py similar to transformers.

I could put it also in the docs subsection as well, but as we're mimicking it twice I'd rather we wait until doc-specific dependencies are needed, then it may be a good idea to have a deps_list util similar to that of transformers. For now though I think that's unnecessary.

@muellerzr muellerzr requested a review from sgugger June 23, 2022 18:25
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 23, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me think I need to migrate the doc styling to use the one in hf-doc-builder ;-)

@muellerzr muellerzr merged commit 3a5490b into main Jun 23, 2022
@muellerzr muellerzr deleted the docbuilder branch June 23, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants