Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bfloat16 weights in disk offload without adding memory overhead #461

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Handle bfloat16 weights in disk offload without adding memory overhead #461

merged 1 commit into from
Jun 22, 2022

Conversation

noamwies
Copy link
Contributor

No description provided.

@noamwies noamwies changed the title Handle bfloat16 weights in disk offload without adding memory overhead… Handle bfloat16 weights in disk offload without adding memory overhead Jun 22, 2022
@noamwies
Copy link
Contributor Author

noamwies commented Jun 22, 2022

This PR handles a bug reported in #454 concerning bfloat16 and disk offload.

@muellerzr muellerzr requested a review from sgugger June 22, 2022 13:02
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 22, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! This will avoid storage to blow up with disk offload, thanks a lot!

@sgugger sgugger merged commit d39c57c into huggingface:main Jun 22, 2022
@noamwies noamwies deleted the bfloat16_offload branch June 22, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants