Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right conditional to stepping #459

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Fix right conditional to stepping #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/by_feature/gradient_accumulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def training_function(config, args):
# We use the new `no_sync` context manager to prevent gradient averaging
# until we want to at the proper step if we happen to be in a distributed setup
# otherwise it does nothing
if step % gradient_accumulation_steps == 0:
if step % gradient_accumulation_steps != 0:
# Accumulate gradients locally
with accelerator.no_sync(model):
output = model(**batch)
Expand Down