Offload and modules with unused submodules #442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with models with unused submodules combined with offload (on CPU and disk). By unused submodules, we mean a something like the
ModuleWithUnusedSubModules
introduced in the test file in this PR: a module that defines a submodule, but does not call it during its forward, just does some operations using its weights.Currently, the offload will fail for such modules because the weights are fetched in a pre-forward hook and the forward method is never called. This PR fixes that by introducing a new argument named
load_all_weights_classes
(if you have any better suggestion, please let me know as I'm not super happy with this name) which contains the name of such submodules used (likeno_split_module_classes
contains the names of the modules that shouldn't be split across devices).