Hotfix all failing GPU tests #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
muellerzr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix all GPU tests and include new makefile commands
What does this add?
This PR introduces a few hotfixes for the issues described in #402
Specifically it fixes the
Makefileso that a user can runmake test_cpuandmake test_cudarather thanmake test(and actually has them work)Why is it needed?
The solution proposed in #402 include separating out the
debug_launcherrelated tests into their own group that they can then be ran separately when doing tests. This is a hotfix while we work towards figuring out how to solve thedebug_launcheritself.