Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepSpeed and FSDP plugin support through script #356

Merged
merged 2 commits into from
May 11, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Setting env variables when DeepSpeed /FSDP plugins are provided directly through script without using accelerate launch utility.

Setting env variables when DeepSpeed /FSDP plugins are provided directly through script without using accelerate launch.
@pacman100 pacman100 requested a review from sgugger May 11, 2022 03:42
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for fixing this!

@pacman100 pacman100 merged commit 45359a7 into huggingface:main May 11, 2022
@pacman100 pacman100 deleted the smangrul/deepspeed-script-fix branch May 11, 2022 14:08
@vinc1am
Copy link

vinc1am commented May 11, 2022

Thanks a lot!! @sgugger @pacman100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants