Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prompt for num_processes #347

Merged
merged 3 commits into from
May 6, 2022
Merged

Fix prompt for num_processes #347

merged 3 commits into from
May 6, 2022

Conversation

pacman100
Copy link
Contributor

@pacman100 pacman100 commented May 6, 2022 •
edited
Loading

Why this PR?

  1. Fixes the placeholder in case of MULIT_GPU, MULTI_CPU and TPU.
  2. Adds support of num_processes for FSDP and DeepSpeed.

@pacman100 pacman100 requested review from muellerzr and sgugger May 6, 2022 11:43
sgugger
sgugger approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 6, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pacman100 added 2 commits May 6, 2022 17:28
@pacman100
Fix prompting
fb251fd 
Handling FSDP and DeepSpeed num_processes while prompting.
@pacman100
quality
f28e441
@pacman100 pacman100 merged commit b923e13 into huggingface:main May 6, 2022
@pacman100 pacman100 deleted the prompt_fix branch May 6, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @sgugger